Draft
Conversation
8 tasks
GustavoStingelin
approved these changes
Aug 22, 2025
Collaborator
GustavoStingelin
left a comment
GustavoStingelin
left a comment
There was a problem hiding this comment.
just one comment, but LGTM!
| ```go | ||
| // MempoolObserver provides methods for observing the mempool of a full node. | ||
| // This is an optional interface that a ChainDriver may implement. | ||
| type MempoolObserver interface { |
Collaborator
There was a problem hiding this comment.
The observer name here reminds me of the Observer Pattern, but the purpose seems to be a bit different, right?
Collaborator
Author
There was a problem hiding this comment.
correct - this is more like providing a mempool IO, tho the whole ntft uses the publish-subscribe pattern, which I believe is the same as the observer pattern you linked.
Collaborator
Author
|
Turning this into a draft as this PR serves as a reference point atm - we will update the design docs once the whole series is done, as I'm working on the wallet interfaces, I realized there are a few places that need to be fine-tuned. |
yyforyongyu
force-pushed
the
add-design-docs
branch
from
462e54c to
7fe773d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds architecture design docs so other tasks can use them as references.