only add the version header if it is missing

[pdinc-oss]

No description provided.

[sergeyromanov]

Thanks for the patch! Any chance you could add a test for that?

[pdinc-oss]

-----Original Message-----
From: ?????? ??????? [mailto:notifications@github.com]
Sent: Wednesday, June 18, 2014 10:25
To: btrott/Crypt-OpenPGP
Cc: pdinc-oss
Subject: Re: [Crypt-OpenPGP] only add the version header if
it is missing (#13)

Thanks for the patch! Any chance you could add a test for that?

Reply to this email directly or view it on GitHub
<#13 (comment)
46442137> . https://github.com/notifications/beacon/2179490
__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxODcyMDcy
MSwiZGF0YSI6eyJpZCI6MzQ5NTE4OTV9fQ==--08e8d6cd57e0267e5cb7aff8
335f163d46c5cc66.gif>

Off to learning the test section of the code...

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

•                                                           -
  

• Jason Pyeron PD Inc. http://www.pdinc.us -
• Principal Consultant 10 West 24th Street #100 -
• +1 (443) 269-1555 x333 Baltimore, Maryland 21218 -

•                                                           -
  

  -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  This message is copyright PD Inc, subject to license 20080407P00.

[guillemj]

The latest OpenPGP RFC9580 states that implementations SHOULD NOT emit this header w/o user consent (ref https://www.rfc-editor.org/rfc/rfc9580.html#name-version-armor-header), and I think mot implementations nowadays do not emit it even if they have not yet implemented that RFC and are still following RFC4880.