fix: Clone options object before mutating it#225
Open
oliverwoodings wants to merge 1 commit intobublejs:masterfrom
Open
fix: Clone options object before mutating it#225oliverwoodings wants to merge 1 commit intobublejs:masterfrom
oliverwoodings wants to merge 1 commit intobublejs:masterfrom
Conversation
Author
|
I have no idea why tests are failing in node 8, it works absolutely fine locally |
be58c50 to
33f5dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a weird stateful bug where a single comment-based JSX pragma declaration can change the pragma used for all subsequent transforms.
The issue is caused by the options object being mutated by the
transform()function. In particular, it is done when a@jsxdirective comment is found in a file. If you then re-use the same options object instance for your next transform call (which coincidentally is what is done bybuble-loader), you will be potentially passing through an incorrect JSX pragma.Example
The solution I have implemented here is to shallow-clone the options object before mutating it.