Fix inline attachment processing with strategy pattern implementation#284
Merged
butschster merged 7 commits intomasterfrom Jul 19, 2025
Merged
Fix inline attachment processing with strategy pattern implementation#284butschster merged 7 commits intomasterfrom
butschster merged 7 commits intomasterfrom
Conversation
…development fixes #280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Problem
When emails contain inline attachments (like QR codes or logos) without explicit filenames that are referenced using
cid:ATTACHMENT_IDin the email body, the SMTP module throws aFileOperationException:This happens because the storage system can't determine the MIME type from a malformed file path when the attachment lacks a proper filename.
🔧 Solution
Implemented a strategy pattern to handle different types of email attachments with appropriate filename generation and processing logic.