Open
Conversation
Contributor
|
Hi @jonls Thanks for reaching out and raising a PR to fix this issue. In the meantime, would you mind adding comments to the newly added code to give some additional context? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Celery sometimes calls the
failure_handlerwith a string for thetracebackparameter instead of an actual traceback object. This was reported in #372 (there's a comment on that request from @clr182 which I think has a misunderstanding about what the issue is about). Other users running into the same issue with Celery a long time ago: celery/celery#806 Here's another Celery user with a similar issue more recently, and a similar fix: scoutapp/scout_apm_python#708Design
Celery should probably be fixed to supply the traceback object in all cases but I haven't had time to dig into that bug. Even if fixed, the old versions of Celery will be used for some time so a workaround in this library seems reasonable.
Changeset
Changed
failure_handlerto get the traceback object from a different place if thetracebacksupplied to the function is a string.Testing
Tested manually. I don't see any existing test cases that are setup to handle the celery integration. Please let me know if I missed these.