fix: Update @Value annotations and properties-maven-plugin to correctly reference property keys#3
Open
Gumparthypavankumar wants to merge 1 commit intobuild-on-aws:mainfrom
Open
Conversation
…ion to enable proper property loading in fat JAR 1. What Changed? * Updated the @value annotations in controller to correctly reference properties, now using {} i.e @value("${property.key}") * Updated the properties-maven-plugin execution phase from package -> initialize to ensure property files are included into the final JAR 2. What is the reason for change? * The original code had @value annotations without curly brackets as a result spring does not resolve properties, and application did not throw errors even though properties were not being loaded * The previous configuration of properties-maven-plugin did not copy property files in generated JAR 3. Is there anything to watch out for anything particularly remarkable? * This fix addresses the issue of missing properties and inconsistent property resolution. There is nothing remarkable to note beyond standard fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.