Build perf: speed up bullet3 build by creating PCH files#4769
Open
es110 wants to merge 1 commit intobulletphysics:masterfrom
Open
Build perf: speed up bullet3 build by creating PCH files#4769es110 wants to merge 1 commit intobulletphysics:masterfrom
es110 wants to merge 1 commit intobulletphysics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi bullet3 maintainers
I am a software engineer at Microsoft in the Visual C++ group. As part of our efforts, we've investigated OSS repositories for build throughput opportunities, and we work with the project maintainers to make OSS builds faster.
We've identified an opportunity in bullet3, which improves the Build Throughput by 9.5%, saving 8 seconds of build time.
We believe this contribution would be a net positive for bullet3, and we'd love to work with you to shape it as appropriate for the project. We have done it so that the pch is enabled by default, but we are happy to make it optional.
We've done these measurements on an AMD EPYC 7763 machine on Windows and ran the build 5 times.
Thank you!
-Eve