Allow React 19 as peer dependency in addition to 18#46
Allow React 19 as peer dependency in addition to 18#46msakrejda wants to merge 2 commits intobvaughn:mainfrom
Conversation
Now that 19 is GA, this should be allowed and seems to just work.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think this warning also needs to be updated, but not sure about the wording. Thoughts? |
|
Also, thanks for working on this library! It was really helpful in understanding the details of how Suspense works. |
|
Scratch that, I think I had the wrong version in node_modules. It does error out with 19, with It looks like maybe that API changed (and was renamed). |
|
The release of React 19 likely calls for a version 1.0 release of this library and dropping support for previous experimental versions of React. This is something I'll need to think about some when I get the chance. Hopefully it won't be a major change but I haven't kept up with the |
|
Okay, thanks for weighing in. I'll try to get this to work with 19, and I'll update the PR, but I'm not at all familiar with these APIs so I don't know what I'm doing—I understand these are sensitive changes and they'll take a while to review. |
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0" | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0" |
There was a problem hiding this comment.
I'm not sure what the best way is to support both, so for now I'm only focused on getting it to work with 19.
2 participants
Now that 19 is GA, this should be allowed and seems to just work.