Conversation
Add matches to: - `GlobalType` - `TableType` - `MemoryType` - `TagType`
Add `eq` functions to: - `GlobalType` - `TableType` - `MemoryType` - `TagType`
|
I think its correct. |
|
This looks like it's largely a duplication of this file, would it be possible to avoid reimplementing that file and using the implementations there instead? Reusing an implementation would reduce the need for tests, and otherwise this will need tests as opposed to just adding the methods. |
|
Im afraid that file implements the methods for Its kind of hard to use these since you would first have to create a What would be the appropriate place to add the tests? |
|
The externally-facing Wasmtime types should, I believe, carry the internal types within them (or somewhere within them) which should, I believe, be suitable for passing to that location. It's true that it's perhaps not quite as easy, but to me it'd be worth not having duplication. Tests can go in |
Add Add
matchesfunction to all types structscloses #12193
For the
matchingfunctions it follows these specs.Adds:
ExternType::matchesExternType::eqGlobalType::matchesGlobalType::eqTableType::matchesTableType::eqMemoryType::matchesMemoryType::eqTagType::matchesTagType::eq