fix: skip importing memfd and rustix if std feature is disabled
#12520
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoKim98
force-pushed
the
fix/skip-importing-rustix-if-std-feature-is-disabled
branch
from
7b4b714 to
8ce42d0
Compare
…isabled Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
HoKim98
force-pushed
the
fix/skip-importing-rustix-if-std-feature-is-disabled
branch
from
8ce42d0 to
7879d59
Compare
Member
|
Thanks! Do you know if this is something we can check in CI? For example are there |
github-actions
bot
added
the
wasmtime:api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to import
memfdandrustixcrates if we have disabled thestdfeature.This PR just excludes these packages on
fiberandwasmtimeifstdfeature is disabled.If we don't do this,
libstd.rmetawill be forcibly linked when building a package that links wasmtime in a#![no_std]environment.