Skip to content

Use the new jwks module and update examples#250

Merged
rthellend merged 4 commits intomainfrom
refactor-jwks-part2
Jan 30, 2026
Merged

Use the new jwks module and update examples#250
rthellend merged 4 commits intomainfrom
refactor-jwks-part2

Conversation

@rthellend
Copy link
Collaborator

Description

Use the new jwks module and update examples

Type of change

  • New feature
  • Feature improvement
  • Bug fix
  • Documentation
  • Cleanup / refactoring
  • Other (please explain)

How is this change tested ?

  • Unit tests
  • Manual tests (explain)
  • Tests are not needed

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rthellend, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's approach to managing JSON Web Key Sets (JWKS) by integrating a newly developed, internal jwks module. This change aims to consolidate and simplify the logic for fetching and validating public keys from various identity providers, moving away from the previously used lestrrat-go/jwx library. The update impacts key components like the token manager and example applications, making the system more consistent and potentially easier to maintain.

Highlights

  • Introduction of New JWKS Module: A dedicated jwks module has been introduced to centralize and standardize the handling of JSON Web Key Sets across the project.
  • Replacement of lestrrat-go/jwx: The external lestrrat-go/jwx library has been replaced by the new internal jwks module for managing JWKS, reducing external dependencies and simplifying key management logic.
  • Refactored JWKS Handling: The jwks.Remote component is now used across the backend and oauth2server examples, as well as the core tokenmanager, to fetch, cache, and retrieve public keys from trusted issuers.
  • Dependency Updates: go.mod and go.sum files have been updated to reflect the removal of the lestrrat-go/jwx dependency and the addition of the new jwks module and hashicorp/go-retryablehttp.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a well-executed refactoring that introduces a new jwks module to centralize the handling of JSON Web Key Sets. This new module encapsulates the logic for fetching, caching, and parsing remote JWKS, which was previously duplicated across tokenmanager and the example applications. The changes significantly simplify the existing code, improve reusability, and enhance maintainability. The implementation of the new module and its integration are solid. I've found one minor issue in an accompanying script.

@rthellend rthellend marked this pull request as ready for review January 30, 2026 17:29
@rthellend rthellend merged commit 81110cd into main Jan 30, 2026
5 checks passed
@rthellend rthellend deleted the refactor-jwks-part2 branch January 30, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant