Open
Conversation
- Add KGB_API_URL to test configmap (test mode with localhost:9999) - Skip KGB API check in test mode to avoid connection errors - Add test to verify project deletion is blocked when pods exist - Add check to ensure no pods exist before attempting deletion - Update test descriptions to reflect new deletion conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added KGB API check
Added a check for existing pods in the namespace is always enforced.
Skipped the KGB API check when running in test mode
(i.e., when the URL is localhost:9999 or empty).
Added an informational log when the check is skipped.
This allows the tests to run without requiring a real KGB API.
Added a verification ensuring the namespace has no pods before deletion.
Added a check ensuring deletion is blocked when pods exist in the namespace.
Added a verification ensuring the namespace has no pods before deletion.