Pass recoverable error to IDAS when residual contains NaN#490
Open
Pass recoverable error to IDAS when residual contains NaN#490
Conversation
jbreue16
force-pushed
the
feature/NANerror
branch
from
170041e to
27964e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In e.g. #379 we observed simulations that keep running. This can happen when the residual function computes NaN values but does not pass an (recoverable) error to IDAS, which is added in this PR.
todo
fixes #379
Update
performance benchmark was ambiguous, I suspect there is no relevant change of performance as expected.
A local run of our standard chromatography benchmarks ten times comparing the minimum required compute times showed no clear result:
convergence_comparison_log.txt
https://github.com/cadet/CADET-Verification-Output/tree/2026-01-22_16-12-00_benchmark/checkNAN_2e6179b