Open
Conversation
b962d0d to
4e35a9f
Compare
5fa1c83 to
329536f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visualizations should be added to easy manual assessment of the data.
For now, Ive added a template for a GRM_DG performance benchmark.
We should extract the functionality from
compare_convergence_datato generate peformance and convergence plots. The data for these plots has to be provided in different subfolders and with the same names for the .json files that are generated by cadet-verification. So by running verification twice and storing the output in different folders, we can then run the function to gengerate the plots.