fix(react): support React 17 JSX typing#1465
Merged
Anber merged 2 commits intocallstack:masterfrom Jan 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: fb2444e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
React 17 projects are currently hitting TS errors like:
Property 'children' is missing ...(TS2741)This is related to how
@linaria/reactwires upJSX.IntrinsicElementsforstyled.*.This PR is a follow-up/superset of the discussion in
#1450, but avoids relying on@ts-expect-errorand adds a small regression test.Summary
react.JSX.IntrinsicElementsvia module augmentation.React.JSX.IntrinsicElementsonly when React actually provides it; otherwise fall back to globalJSX.IntrinsicElements.dtslintsuite (packages/react/__dtslint-react17__) that simulates React 17 +jsx: react-jsxand assertsstyled.buttondoes not requirechildren.packages/react/tsconfig.jsontoinclude: ["src"]so build/typecheck don’t accidentally pull in__dtslint*folders.Test plan
pnpm turbo run typecheck test:dts --filter @linaria/reactpnpm lint