fix: prevent invalid YAML when zeebe exporter enabled without camunda…

[dddpaul]

Closes #4961

Summary

• Fix invalid YAML generation when orchestration.exporters.zeebe.enabled: true and orchestration.exporters.camunda.enabled: false
• The else block outputting {} was incorrectly triggered even when the elasticsearch exporter had already been rendered
• Added condition to only output {} when zeebe exporter is also disabled

Root Cause

In _application-unified.yaml, the else {} block at line 359 was paired with the camunda exporter if condition, not coordinated with the elasticsearch/opensearch exporter blocks. This caused {} to be appended after the elasticsearch config, producing invalid YAML:

numberOfReplicas: "1" {}

Fix

  -    {{- else -}}
  +    {{- else if not .Values.orchestration.exporters.zeebe.enabled -}}
         {{ " {}" }}

Test plan

• Verified with helm template that the fix produces valid YAML
• Unit tests pass

Verification command:

  cat << 'EOF' > /tmp/test-values.yaml
  global:
    security:
      authentication:
        method: basic
    elasticsearch:
      enabled: true
  elasticsearch:
    enabled: true
  identity:
    enabled: false
  identityPostgresql:
    enabled: false
  identityKeycloak:
    enabled: false
  optimize:
    enabled: false
  connectors:
    enabled: false
  orchestration:
    exporters:
      camunda:
        enabled: false
      zeebe:
        enabled: true
  EOF
  helm template camunda charts/camunda-platform-8.8 -f /tmp/test-values.yaml | grep -A12 "# zeebe.broker.exporters"

Expected output (no {} after numberOfReplicas):

          # zeebe.broker.exporters
          exporters:
            elasticsearch:
              className: "io.camunda.zeebe.exporter.ElasticsearchExporter"
              args:
                url: "http://camunda-elasticsearch:9200"
                index:
                  prefix: "zeebe-record"
                  numberOfReplicas: "1"

[CLAassistant]

All committers have signed the CLA.