fix!: remove deprecated secret keys and secret autogeneration for camunda 8.9#5100
Open
fix!: remove deprecated secret keys and secret autogeneration for camunda 8.9#5100
Conversation
51767b0 to
1fedc2a
Compare
4f7d2cd to
96544b2
Compare
9cb88aa to
469b0ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Closes #4839
Closes #5104
What's in this PR?
Removes all deprecated secret configuration keys from chart 8.9 that were deprecated in 8.8 with the new secret standard (
secret.existingSecret/existingSecretKey/inlineSecret). Also removes autogenerated secret functionality (global.secrets.autoGeneratedand thesecret-camunda.yamltemplate), eliminating the need for users to provide initial passwords and improving the default security posture.values.yaml & schema:
values.yamlacross 14 config sections (identity auth, connectors, orchestration, optimize, web-modeler, elasticsearch, keycloak, postgresql)global.secretsconfiguration block (autoGenerated, name, annotations)values.schema.jsonDeleted legacy templates:
templates/common/secret-camunda.yaml— autogenerated secret template (removed, users must provide credentials)identity/postgresql-secret.yaml— legacy Identity PostgreSQL secretweb-modeler/secret-restapi.yaml— legacy Web Modeler REST API secretTemplate cleanup (14 files):
shouldAutogenerateSecrethelper function and simplifynormalizeSecretConfiguration_helpers.tpland deployment templatesplaintextKey/legacyKeyFieldparams from secret config helper callskeyRemovedconstraints inconstraints.tplfor deprecated keys andautoGeneratedsettings with actionable migration messagesIntegration test migration (15 files):
existingSecret.name(object form) and top-levelexistingSecret/existingSecretKeyto the newsecret.existingSecret+secret.existingSecretKeyformatautoGenerated: falsesettings from test valuesexistingSecretKeyvalues alongside everyexistingSecretreferenceUnit tests:
secret_test.go,helpers_autogenerate_secret_test.go,goldenfiles_test.go,secret-camunda.golden.yaml)Checklist
Before opening the PR:
make go.update-golden-only.After opening the PR: