Open
Conversation
Collaborator
|
This happens because you need to pass an absolute path, now you broke that. |
Contributor
Author
|
Can you specify to which paths, relative or absolute, |
Collaborator
|
I think I saw it wrong when looking at the changes to README initially. I would suggest to make sure both variables are expanded to relative paths before passing them to |
Contributor
Author
|
You probably mean extended to absolute paths, don't you? Perhaps you could describe how you would build the project on windows, giving |
Collaborator
|
Took me a while, but finally had some time to try building master: git submodule update --init
cmake -B build -DIDA_SDK_DIR:FILEPATH=c:\IDA90SP1\idasdk90 -DHEXRAYS_SDK_DIR:FILEPATH=c:\IDA90SP1\idasdk90
cmake --build buildI think things could be improved in a few ways:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building NtRays for Windows, it tries to link against "idasdk90\lib\x64_win_vc_64\ida.lib.lib" which does not exist. Removing the .lib suffix in CMakeLists fixes the problem.
I have also updated the build instructions to make it easier to build the plugin.