Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes from #67, the iOS implementation had issues preventing grayscale and colorMatrix from working correctly:
Processor Override: When both properties were set, each
didSetindependently overwrotelazyImageView.processors, so only the last-set property took effect.Cache Issues: All color matrices shared the same static identifier (
"custom.colorMatrix"), causing incorrect cached images when different matrices were applied. Rendering same image with different filters in a list was impossible, since only the first colorMatrix would take affect and be applied to all other images.Changes:
Added
updateProcessors()method that consolidates both processors into a single array, called by bothdidSetblocks. This allows both transformations to be applied.Skips the color matrix processor when an identity matrix is detected, avoiding unnecessary overhead.
Replaced static identifier with hash-based generation (
generateColorMatrixIdentifier()). Each unique matrix now gets a unique cache key, preventing collisions while allowing proper cache reuse for identical matrices.Format:
"custom.colorMatrix.<16-char-hex-hash>"