-
Notifications
You must be signed in to change notification settings - Fork 10
feat: store presets as YAML rather than Go #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: store presets as YAML rather than Go #152
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dimaqq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review, just commenting to show that I really appreciate this change! ❤️
benhoyt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other comment: I'd expect to see a few minor updates to README.md mentioning this where it talks about presets.
This PR migrates built-in configuration presets from hard-coded Go structs to embedded YAML files, making presets easier to edit and ship while keeping them available at runtime. This should also make it simpler for users to develop their own config by starting from an appropriate preset.
Changes:
presets/and embedded them into the binary via go:embed.internal/configto enumerate/read presets from the embedded filesystem.channeloptional for snaps, defaulting tolatest/stable.Fixes #103.