-
Notifications
You must be signed in to change notification settings - Fork 155
Add create local storage unit test #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
houwenchen
wants to merge
6
commits into
caoyingjunz:master
Choose a base branch
from
houwenchen:add-CreateLocalStorage-unit-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
33add22
add ls initialization in init func
houwenchen c0c9c36
add create localstorage unit test
houwenchen b46dfb9
add create localstorage unit test
houwenchen ca9e027
Update main.go
houwenchen 28a83e0
update
houwenchen 5231545
update
houwenchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /* | ||
| Copyright 2021 The Caoyingjunz Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package storage | ||
|
|
||
| import ( | ||
| "context" | ||
| "reflect" | ||
| "testing" | ||
| "time" | ||
|
|
||
| v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
|
|
||
| clientsetfake "github.com/caoyingjunz/csi-driver-localstorage/pkg/client/clientset/versioned/fake" | ||
| "github.com/caoyingjunz/csi-driver-localstorage/pkg/client/informers/externalversions" | ||
| "github.com/caoyingjunz/csi-driver-localstorage/pkg/util/storage" | ||
| "github.com/caoyingjunz/csi-driver-localstorage/testing/wrapper" | ||
| ) | ||
|
|
||
| var ( | ||
| ls = []runtime.Object{ | ||
| wrapper.MakeLocalStorage().WithName("ls-node1").WithNode("node1").Obj(), | ||
| } | ||
| ) | ||
|
|
||
| func TestCreateLocalStorage(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| nodeName string | ||
| expect []string | ||
| }{ | ||
| { | ||
| name: "create-ls-node1", | ||
| nodeName: "node1", | ||
| expect: []string{"ls-node1"}, | ||
| }, | ||
| { | ||
| name: "create-ls-node2", | ||
| nodeName: "node2", | ||
| expect: []string{"ls-node1", "ls-node2"}, | ||
| }, | ||
| { | ||
| name: "re-create-ls-node2", | ||
| nodeName: "node2", | ||
| expect: []string{"ls-node1", "ls-node2"}, | ||
| }, | ||
| } | ||
|
|
||
| ctx := context.Background() | ||
|
|
||
| lsClient := clientsetfake.NewSimpleClientset(ls...) | ||
| informerFactory := externalversions.NewSharedInformerFactory(lsClient, 1*time.Second) | ||
| informerFactory.Start(ctx.Done()) | ||
| informerFactory.WaitForCacheSync(ctx.Done()) | ||
|
|
||
| for _, test := range tests { | ||
| if err := storage.CreateLocalStorage(lsClient, test.nodeName); err != nil { | ||
| t.Errorf("case name: %s, create localstorage failed, err: %v\n", test.name, err) | ||
| } | ||
|
|
||
| lsList, err := lsClient.StorageV1().LocalStorages().List(ctx, v1.ListOptions{}) | ||
| if err != nil { | ||
| t.Errorf("case name: %s, list localstorage failed, err: %v\n", test.name, err) | ||
| } | ||
|
|
||
| if len(lsList.Items) != len(test.expect) { | ||
| t.Errorf("case name: %s, expected ls num is not equal get", test.name) | ||
| } | ||
|
|
||
| var lsSet []string | ||
| for _, ls := range lsList.Items { | ||
| lsSet = append(lsSet, ls.Name) | ||
| } | ||
|
|
||
| if !reflect.DeepEqual(lsSet, test.expect) { | ||
| t.Errorf("case name: %s, after create localstorage, got is not equal expect", test.name) | ||
| } | ||
|
|
||
| t.Logf("case name: %s tests succeed", test.name) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| Copyright 2021 The Caoyingjunz Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package wrapper | ||
|
|
||
| import ( | ||
| v1 "k8s.io/api/core/v1" | ||
|
|
||
| localstoragev1 "github.com/caoyingjunz/csi-driver-localstorage/pkg/apis/localstorage/v1" | ||
| ) | ||
|
|
||
| type NodeWrapper struct{ v1.Node } | ||
|
|
||
| func MakeNode() *NodeWrapper { | ||
| return &NodeWrapper{v1.Node{}} | ||
| } | ||
|
|
||
| // 返回内部封装的 node | ||
| func (n *NodeWrapper) Obj() *v1.Node { | ||
| return &n.Node | ||
| } | ||
|
|
||
| // 为 node 设置 name | ||
| func (n *NodeWrapper) WithName(name string) *NodeWrapper { | ||
| n.SetName(name) | ||
| return n | ||
| } | ||
|
|
||
| type LocalStorageWrapper struct{ localstoragev1.LocalStorage } | ||
|
|
||
| func MakeLocalStorage() *LocalStorageWrapper { | ||
| return &LocalStorageWrapper{localstoragev1.LocalStorage{}} | ||
| } | ||
|
|
||
| // 返回内部封装的 LocalStorage | ||
| func (ls *LocalStorageWrapper) Obj() *localstoragev1.LocalStorage { | ||
| return &ls.LocalStorage | ||
| } | ||
|
|
||
| // 为 LocalStorage 设置 name | ||
| func (ls *LocalStorageWrapper) WithName(name string) *LocalStorageWrapper { | ||
| ls.SetName(name) | ||
| return ls | ||
| } | ||
|
|
||
| // 为 LocalStorage 设置 node | ||
| func (ls *LocalStorageWrapper) WithNode(node string) *LocalStorageWrapper { | ||
| ls.Spec.Node = node | ||
| return ls | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.