allow procs as command map values#310
Conversation
mikz
force-pushed
the
improve-command-map
branch
from
7ead5c7 to
278de3e
Compare
|
@mattbrictson could I get a 2nd opinion on this please? |
|
@mikz looks like recently merged PRs have caused some conflicts, would you mind rebasing? |
mikz
force-pushed
the
improve-command-map
branch
from
278de3e to
1130b11
Compare
|
@leehambley rebased |
mikz
force-pushed
the
improve-command-map
branch
from
1130b11 to
7ea7a1b
Compare
Cheers :) |
|
@leehambley I am not really a big user of the command map (the only entry I ever have is |
That's my take too, so @mikz if you can rebase this so we can merge it, I'd be more than happy. Thanks |
mikz
force-pushed
the
improve-command-map
branch
from
7ea7a1b to
9ed24c7
Compare
|
@leehambley rebased. Cheers. The use case here is to use |
|
@mikz merging because I totally see the usecase, and applaud you for using your distro's package manager rather than putting rbenv and rvm in places I don't think they belong! 👍 Caveat: there's a few open issues around the command map, and we're addressing them on a first-come-first-served basis, as matt and I aren't huge consumers of this feature... Everything subject to change. .. |
|
@leehambley Looks like you meant to merge this one? |
so this example works properly:
SSHKit.config.command_map[:bundle] = -> { "#{fetch(:ruby_cmd)} /usr/bin/local/bundle" }
mikz
force-pushed
the
improve-command-map
branch
from
9ed24c7 to
b8817e6
Compare
|
@mattbrictson @leehambley rebased this. This could be merged regardless the future of #311. |
allow procs as command map values
|
🚀 thanks @mikz |
|
FYI, this didn't make the cut for SSHKit 1.9. It will go in 1.10. |
## [1.11.3][] (2016-09-16)
* Fix known_hosts caching to match on the entire hostlist
[PR #364](capistrano/sshkit#364) @byroot
## [1.11.2][] (2016-07-29)
### Bug fixes
* Fixed a crash occurring when `Host@keys` was set to a non-Enumerable.
@xavierholt [PR #360](capistrano/sshkit#360)
## [1.11.1][] (2016-06-17)
### Bug fixes
* Fixed a regression in 1.11.0 that would cause
`ArgumentError: invalid option(s): known_hosts` in some older versions of
net-ssh. @byroot [#357](capistrano/sshkit#357)
## [1.11.0][] (2016-06-14)
### Bug fixes
* Fixed colorized output alignment in Logger::Pretty. @xavierholt
[PR #349](capistrano/sshkit#349)
* Fixed a bug that prevented nested `with` calls
[#43](capistrano/sshkit#43)
### Other changes
* Known hosts lookup optimization is now enabled by default. @byroot
## 1.10.0 (2016-04-22)
* You can now opt-in to caching of SSH's known_hosts file for a speed boost
when deploying to a large fleet of servers. Refer to the
[README](https://github.com/capistrano/sshkit/tree/v1.10.0#known-hosts-caching) for
details. We plan to turn this on by default in a future version of SSHKit.
[PR #330](capistrano/sshkit#330) @byroot
* SSHKit now explicitly closes its pooled SSH connections when Ruby exits;
this fixes `zlib(finalizer): the stream was freed prematurely` warnings
[PR #343](capistrano/sshkit#343) @mattbrictson
* Allow command map entries (`SSHKit::CommandMap#[]`) to be Procs
[PR #310](capistrano/sshkit#310)
@mikz
## 1.9.0
**Refer to the 1.9.0.rc1 release notes for a full list of new features, fixes,
and potentially breaking changes since SSHKit 1.8.1.** There are no changes
since 1.9.0.rc1.
## 1.9.0.rc1
### Potentially breaking changes
* The SSHKit DSL is no longer automatically included when you `require` it.
**This means you must now explicitly `include SSHKit::DSL`.**
See [PR #219](capistrano/sshkit#219) for details.
@beatrichartz
* `SSHKit::Backend::Printer#test` now always returns true
[PR #312](capistrano/sshkit#312) @mikz
### New features
* `SSHKit::Formatter::Abstract` now accepts an optional Hash of options
[PR #308](capistrano/sshkit#308) @mattbrictson
* Add `SSHKit::Backend.current` so that Capistrano plugin authors can refactor
helper methods and still have easy access to the currently-executing Backend
without having to use global variables.
* Add `SSHKit.config.default_runner` options that allows to override default command runner.
This option also accepts a name of the custom runner class.
* The ConnectionPool has been rewritten in this release to be more efficient
and have a cleaner internal API. You can still completely disable the pool
by setting `SSHKit::Backend::Netssh.pool.idle_timeout = 0`.
@mattbrictson @byroot [PR #328](capistrano/sshkit#328)
### Bug fixes
* make sure working directory for commands is properly cleared after `within` blocks
[PR #307](capistrano/sshkit#307)
@steved
* display more accurate string for commands with spaces being output in `Formatter::Pretty`
[PR #304](capistrano/sshkit#304)
@steved
[PR #319](capistrano/sshkit#319) @mattbrictson
* Fix a race condition experienced in JRuby that could cause multi-server
deploys to fail. [PR #322](capistrano/sshkit#322)
@mattbrictson
3 participants
so this example works properly: