V5 - Fix sdist build and add CI job for testing it.#2623
Merged
kabeor merged 2 commits intocapstone-engine:v5from Feb 7, 2025
Merged
V5 - Fix sdist build and add CI job for testing it.#2623kabeor merged 2 commits intocapstone-engine:v5from
kabeor merged 2 commits intocapstone-engine:v5from
Conversation
Rot127
force-pushed
the
v5-cmake-cpack-build-fix
branch
from
724cb48 to
3bb685b
Compare
Rot127
force-pushed
the
v5-cmake-cpack-build-fix
branch
2 times, most recently
from
9a0d5b9 to
d59d33a
Compare
Rot127
force-pushed
the
v5-cmake-cpack-build-fix
branch
from
d59d33a to
fac24e1
Compare
kabeor
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Companion to #2622
The sdist build was not tested before. Hence we didn't detect issues with it.
This fixes the build (missing files in sdist archive) and adds a new test for it as job.
Test plan
Added
Closing issues
closes #2621