Skip to content

bash: reduce xargs calls #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsteube merged 1 commit into from
Oct 20, 2025
Merged

bash: reduce xargs calls #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions example/cmd/_test/bash-ble.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ _example_completion() {

local nospace data compline="${COMP_LINE:0:${COMP_POINT}}"

if echo "${compline}''" | xargs echo 2>/dev/null > /dev/null; then
data=$(echo "${compline}''" | xargs example _carapace bash)
elif echo "${compline}'" | xargs echo 2>/dev/null > /dev/null; then
data=$(echo "${compline}'" | xargs example _carapace bash)
else
data=$(echo "${compline}\"" | xargs example _carapace bash)
data=$(echo "${compline}''" | xargs example _carapace bash 2>/dev/null)
if [ $? -eq 1 ]; then
data=$(echo "${compline}'" | xargs example _carapace bash 2>/dev/null)
if [ $? -eq 1 ]; then
data=$(echo "${compline}\"" | xargs example _carapace bash 2>/dev/null)
fi
fi

IFS=$'\001' read -r -d '' nospace data <<<"${data}"
Expand Down
12 changes: 6 additions & 6 deletions example/cmd/_test/bash.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ _example_completion() {

local nospace data compline="${COMP_LINE:0:${COMP_POINT}}"

if echo "${compline}''" | xargs echo 2>/dev/null > /dev/null; then
data=$(echo "${compline}''" | xargs example _carapace bash)
elif echo "${compline}'" | xargs echo 2>/dev/null > /dev/null; then
data=$(echo "${compline}'" | xargs example _carapace bash)
else
data=$(echo "${compline}\"" | xargs example _carapace bash)
data=$(echo "${compline}''" | xargs example _carapace bash 2>/dev/null)
if [ $? -eq 1 ]; then
data=$(echo "${compline}'" | xargs example _carapace bash 2>/dev/null)
if [ $? -eq 1 ]; then
data=$(echo "${compline}\"" | xargs example _carapace bash 2>/dev/null)
fi
fi

IFS=$'\001' read -r -d '' nospace data <<<"${data}"
Expand Down
18 changes: 9 additions & 9 deletions internal/shell/bash/snippet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@ import (
// Snippet creates the bash completion script.
func Snippet(cmd *cobra.Command) string {
result := fmt.Sprintf(`#!/bin/bash
_%v_completion() {
_%[1]v_completion() {
export COMP_LINE
export COMP_POINT
export COMP_TYPE
export COMP_WORDBREAKS

local nospace data compline="${COMP_LINE:0:${COMP_POINT}}"

if echo "${compline}''" | xargs echo 2>/dev/null > /dev/null; then
data=$(echo "${compline}''" | xargs %v _carapace bash)
elif echo "${compline}'" | xargs echo 2>/dev/null > /dev/null; then
data=$(echo "${compline}'" | xargs %v _carapace bash)
else
data=$(echo "${compline}\"" | xargs %v _carapace bash)
data=$(echo "${compline}''" | xargs %[2]v _carapace bash 2>/dev/null)
if [ $? -eq 1 ]; then
data=$(echo "${compline}'" | xargs %[2]v _carapace bash 2>/dev/null)
if [ $? -eq 1 ]; then
data=$(echo "${compline}\"" | xargs %[2]v _carapace bash 2>/dev/null)
fi
fi

IFS=$'\001' read -r -d '' nospace data <<<"${data}"
Expand All @@ -36,8 +36,8 @@ _%v_completion() {
[[ "${COMPREPLY[*]}" == "" ]] && COMPREPLY=() # fix for mapfile creating a non-empty array from empty command output
}

complete -o noquote -F _%v_completion %v
`, cmd.Name(), uid.Executable(), uid.Executable(), uid.Executable(), cmd.Name(), cmd.Name())
complete -o noquote -F _%[1]v_completion %v
`, cmd.Name(), uid.Executable())

return result
}