Open
Conversation
profnandaa
reviewed
Oct 2, 2018
Collaborator
profnandaa
left a comment
profnandaa
left a comment
There was a problem hiding this comment.
Thanks for Anna your PR! 🎉
See my comment below.
In addition:
- Fix the formatting, 2 spaces for tab will be good -- and be consistent. We'll add a linter later to help with this.
- Instead of deleting the previous code, could your create a different file, e.g.
sortedMerge-2.js
| p1++; | ||
| } | ||
| else { | ||
| a.splice(p1,0,b[p2]); |
Collaborator
There was a problem hiding this comment.
These slices might/will actually be expensive for large inputs; think about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shorter solution to the sortedMerge problem