Not handled second part of the question#50
Open
patlolla-sai-charan-reddy wants to merge 1 commit intocareercup:masterfrom
Open
Not handled second part of the question#50patlolla-sai-charan-reddy wants to merge 1 commit intocareercup:masterfrom
patlolla-sai-charan-reddy wants to merge 1 commit intocareercup:masterfrom
Conversation
` If the "compressed" string would not become smaller than the original string, your method should return the original string`
profnandaa
reviewed
Aug 24, 2019
| // Test | ||
| console.log('aaaaaa', strComp('aaaaaa'), 'a6'); | ||
| console.log('aabcccccaaa', strComp('aabcccccaaa'), 'a2b1c5a3'); No newline at end of file | ||
| console.log('aaaaaa', stringCompression('aabcdef')); // aabcdef |
Collaborator
There was a problem hiding this comment.
Why not a2bcdef for this one? I'm thinking that the only stuff you should not compress is when the rep is 1, but for anything more than that, will be good to compress -- for simplicity sake. Though I understand |a2| == |aa|
Contributor
Author
There was a problem hiding this comment.
sorry for the late response.
per my understanding of the question, if the length of the output is greater then or equal to the length of input we should simply return the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the "compressed" string would not become smaller than the original string, your method should return the original string