[Activity Recognition] Fix NullPointerException in the Android plugin#1141
Open
DrumRobot wants to merge 5 commits intocarp-dk:masterfrom
Open
[Activity Recognition] Fix NullPointerException in the Android plugin#1141DrumRobot wants to merge 5 commits intocarp-dk:masterfrom
DrumRobot wants to merge 5 commits intocarp-dk:masterfrom
Conversation
…dk#449) - Added null check before calling `eventSink.success(result)` - Fixes intermittent crashes when reloading the app - Resolves carp-dk#449
…k#580) - Added null checks for `ActivityRecognitionResult`, `getProbableActivities()`, and `SharedPreferences` - Prevents potential NullPointerException in `onHandleIntent` - Resolves carp-dk#488, carp-dk#580
…default - Replace R.drawable.common_full_open_on_phone with android.R.drawable.ic_dialog_info - Use Android SDK built-in icon instead of internal Play Services resource - Fix compilation error without adding extra dependencies
This drawable was removed from play-services-base 18.x but is still referenced by ForegroundService.java and ActivityRecognitionFlutterPlugin.java. Adding a placeholder drawable to fix build errors on newer environments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Prevent null
eventSinkcrash inonSharedPreferenceChanged(activity_recognition_flutter 4.0.5+1 #449)eventSink.success(result)Prevent null result crash in
onHandleIntent(Activity Recognition crashes on android 12 #488, CRASH android com.google.android.gms.location.ActivityRecognitionResult.getProbableActivities()' on a null object reference #580)ActivityRecognitionResult,getProbableActivities(), andSharedPreferencesNullPointerExceptioninonHandleIntentWhy?
These changes address crashes that occur due to null references in Android's activity recognition service, improving stability and preventing unexpected app terminations.
Let me know if any modifications are needed! 🚀