Websocket support for word_timestamps that don't have the 'data' field#19
Merged
chongzluong merged 1 commit intocartesia-ai:mainfrom Feb 3, 2025
Merged
Websocket support for word_timestamps that don't have the 'data' field#19chongzluong merged 1 commit intocartesia-ai:mainfrom
chongzluong merged 1 commit intocartesia-ai:mainfrom
Conversation
Contributor
Author
|
I've updated our live code to run with our fork including the fix, and we no longer see the issue. |
chongzluong
approved these changes
Feb 3, 2025
Contributor
chongzluong
left a comment
chongzluong
left a comment
There was a problem hiding this comment.
Appreciate the fix here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for this issue #18
It provides a simple safety check for the presence of the "data" field in a response before trying to access it.