Open
Conversation
wojtekmaj
force-pushed
the
typescript
branch
from
b79c95d to
47566d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to rewrite heic-decode into a native TypeScript. It wasn't easy, especially since libheif-js does not provide any types to begin with, but I ended up with something somewhat usable.
I tried to stay true to the original code and apply only minimal changes, but had to e.g. ditch mocha/chai to get ESM modules working properly.
I did it mostly for my own purposes and decided to share; feel free to take it "as is" and develop further, and feel equally free to just close it, no offense taken.
Note that the "overall" diff shows files added/removed because they are too different overall, but if you dive in to commits and examine diffs there, you'll see the actual edits line by line.