Download zip file into ORACLE_ZIP_DIR if present#17
Closed
jayvdb wants to merge 1 commit intocbandy:masterfrom
Closed
Download zip file into ORACLE_ZIP_DIR if present#17jayvdb wants to merge 1 commit intocbandy:masterfrom
jayvdb wants to merge 1 commit intocbandy:masterfrom
Conversation
If ORACLE_ZIP_DIR is set, the zip file is stored in that directory. This allows the zip file to be located outside of the source tree, and thus in a cachable directory as required for the Travis caching system, which became available on trusty images on 03-05-2016. https://blog.travis-ci.com/2016-05-03-caches-are-coming-to-everyone While the Oracle XE download time is negligible, the downloaded Oracle XE zip is made available to pull requests, whereas currently download.js fails because ORACLE_LOGIN_* environment variables are not available to pull requests. https://docs.travis-ci.com/user/caching/
Owner
|
Merged with some changes in ba62209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ORACLE_ZIP_DIR is set, the zip file is stored in that
directory.
This allows the zip file to be located outside of the source tree,
and thus in a cachable directory as required for the Travis caching
system, which became available on trusty images on 03-05-2016.
https://blog.travis-ci.com/2016-05-03-caches-are-coming-to-everyone
While the Oracle XE download time is negligible, the downloaded
Oracle XE zip is made available to pull requests, whereas currently
download.js fails because ORACLE_LOGIN_* environment variables are
not available to pull requests.
https://docs.travis-ci.com/user/caching/