Add capacity to fluid tank data (1.21.x)#2239
Open
EmmaTheMartian wants to merge 1 commit intocc-tweaked:mc-1.21.xfrom
Open
Add capacity to fluid tank data (1.21.x)#2239EmmaTheMartian wants to merge 1 commit intocc-tweaked:mc-1.21.xfrom
EmmaTheMartian wants to merge 1 commit intocc-tweaked:mc-1.21.xfrom
Conversation
EmmaTheMartian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1629
The Forge implementation feels pretty hacky. I considered trying to change
ComputerCraftAPIImpl#fluidStackDetailsto aDetailRegistry<IFluidTank>or similar, however it seemed like it would have been less compatible or would entail a more breaking change for addon developers.The Fabric implementation was clean-cut.
I also made this change for 1.20.x in another PR. Porting this to 1.21.y should be the exact same.