Fix ensure with nonstandard versions#43
Open
strangelittlemonkey wants to merge 1 commit intoccin2p3:masterfrom
Open
Fix ensure with nonstandard versions#43strangelittlemonkey wants to merge 1 commit intoccin2p3:masterfrom
strangelittlemonkey wants to merge 1 commit intoccin2p3:masterfrom
Conversation
Contributor
|
@strangelittlemonkey thanks for the PR. It would be better to seperate the changes in this PR into multiples PRs so that it can be reviewed easily. For example support for BSD should not include rubocop fixes, etc... By the way the tests are failing, and adding tests for the new features would be awesome too :) Thanks for the understanding |
Contributor
Author
|
The tests are failing on the master branch without this. I can fix them as they stand in that and break that into a separate PR to precede this. |
This increases support for DragonFly BSD as well as FreeBSD, making them first class citizens for this module. Additionally, it creates a new structured fact called perl, which contains the various version numbers that can be referenced for what version of Perl is the system default. It was mainly added to properly support the config paths for the default @inc on DragonFly and FreeBSD. The cpan provider was updated to fix a few bugs around how it handled version strings, and using rubocop, some additional cleanup was done while there.
strangelittlemonkey
force-pushed
the
fix_ensure_with_nonstandard_versions
branch
from
e5b665a to
c13b6e2
Compare
Contributor
Author
|
I've separated them out into two PRs now. |
Contributor
|
Please fix the failing tests |
Member
|
There are insterestinf features in this PR (perl version fact, new os support). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases support for DragonFly BSD as well as FreeBSD, making
them first class citizens for this module. Additionally, it creates a
new structured fact called perl, which contains the various version
numbers that can be referenced for what version of Perl is the system
default. It was mainly added to properly support the config paths for
the default @inc on DragonFly and FreeBSD. The cpan provider was
updated to fix a few bugs around how it handled version strings, and
using rubocop, some additional cleanup was done while there.