Small cleanups and fixes

[mattock]

Hi,

The first commit fixes some (trivial) puppet-lint warnings. From what I've read Puppet 4 does not allow references to relative class names, so "include patterdb" won't work, whereas "include ::patterndb" will. For this reason I fixed those.

Puppet-lint also complained about indentation; the resources are currently defined like this:

resource { 'title':
  long_parameter_name => 'value',
  otherparam => 'value2',
}

Whereas puppet-lint wants them to look like this:

resource { 'title':
  long_parameter_name => 'value',
  otherparam          => 'value2',
}

If you want, I can trivially fix these indentation issues also.

The second commit's primary purpose is to fix installation of syslog-ng on Ubuntu 14.04. It is quite likely that installation was broken on other Debian derivatives also. The commit message contains hopefully adequate explanation of what was done and why.

[faxm0dem]

First of all thank you for your interest in this module and for your PR!

• Knock yourself out for any lint related stuff, I'll merge them as-is as long as they're in a seperate commit (which seems to be the case 👍)
• About the syslog-ng package: I made this really minimal as we actually use the syslog-ng puppet-module instead, which I strongly recommend
• I'm surprised that Ubuntu doesn't allow for both rsyslog and syslog-ng to be installed (as is the case for my Debian 8). Are you using the OS default package?

[mattock]

I'm using the OS default packages. I was also rather surprised that installing syslog-ng did not automatically remove rsyslogd, but that seemed to be the case. So it's not just about not being able to have both installed at the same time.

If a separate syslog-ng module exists, maybe syslog-ng installation should be removed from the patterndb module altogether? I can do that if that's fine with you.

[faxm0dem]

Out of curiosity, which files conflict between rsyslog and syslog-ng?

I'd prefer to have manage_package set to false by default, and keep the current behaviour: some people use other package sources, which enable keeping both rsyslog and syslog-ng.

Finally, separating the OS defaults in params.pp is nice, so please keep that.