Merged
Conversation
Using Hiera hierarchy, we can provide a default value that makes sense for the current operating system and still allow the user to provide their own custom package name if necessary. Makes the code simpler without changing the logic.
This directory is operating-system dependant.
These directory only make sense on some operating systems and should already be part of base system or the syslog-ng package. Do need to manage these in the patterndb module.
According to hier(7), /var/cache/ is used to store miscellaneous cached files, precisely what merged patterns not yet installed are.
The variable was removed, so no need for a default value and we should not see references to it in the README.
These versions or CentOS have reached end-of-life and the images used for CI are not available anymore. As we cannot ensure these legacy systems are still working with the module, remove them from metadata.json.
faxm0dem
approved these changes
Jan 15, 2025
faxm0dem
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These versions or CentOS have reached end-of-life and the images used
for CI are not available anymore. As we cannot ensure these legacy
systems are still working with the module, remove them from
metadata.json.
Also include: