Open
Conversation
auto-merge was automatically disabled
July 6, 2023 09:28
Head branch was pushed to by a user without write access
badmintoncryer
force-pushed
the
feature/addEvaluationPeriods
branch
from
6bd7215 to
3cf4695
Compare
kaizencc
requested changes
Jan 25, 2024
Contributor
kaizencc
left a comment
kaizencc
left a comment
There was a problem hiding this comment.
Hi @badmintoncryer sorry we did not get to this. We don't really monitor cdklabs repos except for good samaritans :). If you're interested in continuing this, I think we'd need at least a unit test. And then please ping me if you need another review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1182