Open
Conversation
tomachine
force-pushed
the
cdn-resource-edit-refactor
branch
from
1655f80 to
886c6a4
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors CDN resource editing by consolidating request building logic and updating various project dependencies and tooling configurations.
Changes:
- Refactored CDN resource creation to extract request building into a separate
createAddRequestmethod - Updated Go version to 1.25.6 and refreshed dependency versions
- Migrated golangci-lint configuration to v2 format with updated linter settings
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/util/api.go | Added blank line for code formatting |
| internal/provider/ssl/all_test.go | Pre-allocated test check function slice with capacity |
| internal/provider/provider.go | Refactored timeout handling to use intermediate variable |
| internal/provider/cdn/cdn.go | Extracted CDN add request building into separate method and simplified edit-after-creation flow |
| internal/provider/cdn/all_test.go | Pre-allocated test check function slice with capacity |
| go.mod | Updated Go version and dependency versions |
| Makefile | Updated golangci-lint import path to v2 |
| .golangci.yml | Migrated to golangci-lint v2 configuration format |
| .github/workflows/test.yml | Updated GitHub Actions versions |
| .github/workflows/release.yml | Updated GitHub Actions checkout version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…cies and GH actions
tomachine
force-pushed
the
cdn-resource-edit-refactor
branch
from
c8350e1 to
a2026b5
Compare
setnicka
approved these changes
Feb 12, 2026
setnicka
left a comment
setnicka
left a comment
There was a problem hiding this comment.
Tested on real account, both creating and editing of a resource (with conditional features) work as expected.
Code checked roughly, in the overall view the changes makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.