Skip to content

Fix tab xpath timeouterror #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanlensky merged 3 commits into from
Oct 19, 2025
Merged

Fix tab xpath timeouterror #219

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e313d1
refactor xpath method to avoid instant timeouterror
ionutcatana Oct 15, 2025
06b6440
update changelog
ionutcatana Oct 15, 2025
5342b10
catch TimeoutError instead of all Exceptions
ionutcatana Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions zendriver/core/tab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,15 +384,17 @@ async def xpath(self, xpath: str, timeout: float = 2.5) -> List[Element]: # noq
items: List[Element] = []
try:
await self.send(cdp.dom.enable(), True)
items = await self.find_all(xpath, timeout=0)
if not items:
loop = asyncio.get_running_loop()
loop = asyncio.get_running_loop()
while not items:
start_time = loop.time()
Copy link
Contributor

@puc9 puc9 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is merged already, but shouldn't the start_time = loop.time() be outside of the while loop? Did I misunderstand the change?
I would also merge the await self.sleep(0.1) into the find_all call.

Copy link
Member

@stephanlensky stephanlensky Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original implementation may have been copied directly from nodriver, bugs included.

Definitely feel free to PR some fixes :)

while not items:
try:
items = await self.find_all(xpath, timeout=0)
await self.sleep(0.1)
if loop.time() - start_time > timeout:
break
except Exception:
pass

await self.sleep(0.1)
if loop.time() - start_time > timeout:
break
finally:
await self.disable_dom_agent()
return items
Expand Down