fix: remove redundant nil check and fix comment#4719
Open
Bashmunta wants to merge 1 commit intocelestiaorg:mainfrom
Open
fix: remove redundant nil check and fix comment#4719Bashmunta wants to merge 1 commit intocelestiaorg:mainfrom
Bashmunta wants to merge 1 commit intocelestiaorg:mainfrom
Conversation
Bashmunta
requested review from
Wondertan,
renaynay,
vgonkivs and
walldiss
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nil-check for leaves in GetSharesByNamespace was unnecessary because CollectLeavesByNamespace returns an error on any retrieval failure, and the absent-namespace path exits before building shares. This could silently skip elements if retained. Also corrected the function comment to reflect actual behavior: errors short-circuit with no shares, while absent namespace returns no shares and a proof with err == nil.