This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add file where function is defined to trace attributes#221
Open
dz0ny wants to merge 1 commit intocensus-instrumentation:masterfrom
Open
Add file where function is defined to trace attributes#221dz0ny wants to merge 1 commit intocensus-instrumentation:masterfrom
dz0ny wants to merge 1 commit intocensus-instrumentation:masterfrom
Conversation
Member
|
Hi @dz0ny, thanks for the contribution. I think it can be a helpful addition in certain cases. Having said that, there are indeed some concerns:
|
Author
|
Yep tests fail because there is new attribute "file" outputted by default. The problem is that a test will fail because diff (because of the absolute path) will always be depended on the environment. SO the question is how to write tests or test in a way where it does not do exact match but just partial, which is required even if feature is disabled by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a) Not sure how open are you about this.
b) It serves a purpose where the function being trace is same across multiple files and you need to know which file has it.
c) There should probably be some config option to enable this as it might impact performance.
I'm open on suggestions...