This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Added note on root logger level#872
Open
snobu wants to merge 1 commit intocensus-instrumentation:masterfrom
Open
Added note on root logger level#872snobu wants to merge 1 commit intocensus-instrumentation:masterfrom
snobu wants to merge 1 commit intocensus-instrumentation:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
lzchen
reviewed
Apr 10, 2020
| logger.warning('Hello, World!') | ||
|
|
||
| **IMPORTANT NOTE:** | ||
| The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_. |
Contributor
There was a problem hiding this comment.
Suggested change
| The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_. | |
| The root logger for the Python logging library has a logging level set to `WARNING <https://docs.python.org/3/library/logging.html#logging.Logger.setLevel>`_ by default. Any logs that are below this level will not actually be logged, and as such, not sent to Application Insights. More on that `here <https://docs.python.org/3/library/logging.html#logging-levels>`_. |
lzchen
approved these changes
Apr 10, 2020
Contributor
lzchen
left a comment
There was a problem hiding this comment.
Looks good! You can pull the latest master to rebase and I'll get this merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#871 for context.