Skip to content

CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository#5597

Merged
omercier merged 1 commit intoCTOR-1656-move-centreon-plugins-sudoers-to-centreon-plugin-repositoryfrom
CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository
Jun 30, 2025
Merged

CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository#5597
omercier merged 1 commit intoCTOR-1656-move-centreon-plugins-sudoers-to-centreon-plugin-repositoryfrom
CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository

Conversation

@Evan-Adam
Copy link
Contributor

Description

Add automated test on the nmap plugin
Add the centroen-plugins-sudoers package to avoid cyclic deps.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

See automated tests, all plugin requiring this lib should be installable without the central package repository

plugin to tests:
centreon-plugin-applications-nmap-cli
centreon-plugin-applications-protocol-dhcp
centreon-plugin-applications-protocol-udp

Automated tests should also pass.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
    • Data used for automated tests are anonymized.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences end with a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@Evan-Adam Evan-Adam marked this pull request as ready for review May 20, 2025 12:13
@Evan-Adam Evan-Adam requested review from a team as code owners May 20, 2025 12:13
@Evan-Adam Evan-Adam requested review from jean-christophe81 and lucie-tirand and removed request for a team May 20, 2025 12:13
@Evan-Adam Evan-Adam force-pushed the CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository branch from 125df02 to 13fcbe1 Compare May 20, 2025 12:21
@Evan-Adam Evan-Adam requested a review from a team as a code owner May 20, 2025 12:21
@Evan-Adam Evan-Adam requested review from ddes and mushroomempires and removed request for a team May 20, 2025 12:21
Evan-Adam added a commit to centreon/centreon that referenced this pull request May 20, 2025
@Evan-Adam Evan-Adam requested a review from a team as a code owner May 20, 2025 12:27
@Evan-Adam Evan-Adam force-pushed the CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository branch from cc7ac3f to 13f3a3f Compare May 20, 2025 15:27
Base automatically changed from CTOR-1649-plugin-apps-nmap-cli-need-to-secure-the-execution-of-commands to develop May 26, 2025 07:29
@github-actions
Copy link

github-actions bot commented Jun 10, 2025

Logo
Checkmarx One – Scan Summary & Details4dfc5aa1-bad0-4650-b557-1ebd090f9397

Great job, no security vulnerabilities found in this Pull Request

@Evan-Adam Evan-Adam force-pushed the CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository branch from 0290a7a to 7cef845 Compare June 11, 2025 09:06
@Evan-Adam Evan-Adam changed the base branch from develop to CTOR-1656-move-centreon-plugins-sudoers-to-centreon-plugin-repository June 11, 2025 09:07
@omercier omercier merged commit c2e7284 into CTOR-1656-move-centreon-plugins-sudoers-to-centreon-plugin-repository Jun 30, 2025
20 checks passed
@omercier omercier deleted the CTOR-1656-plugin-apps-nmap-cli-add-test-and-move-centreon-plugins-sudoers-to-centreon-plugin-repository branch June 30, 2025 09:13
Evan-Adam added a commit to centreon/centreon that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants