Build: fix imagemin EPIPE errors and ensure successful asset generation and changed twitter logo#994
Open
Build: fix imagemin EPIPE errors and ensure successful asset generation and changed twitter logo#994
Conversation
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@baum
Summary
This PR fixes intermittent image build failures caused by
imagemin-mozjpeg(EPIPEerrors) and stabilizes the asset pipeline.The build now completes successfully on Node.js 18 and macOS, with all images optimized and written to


dist/.I have also changed the twitter icon to the new X icon. I will attach images of the new look, before and after.
What changed
npm run buildWhy this is needed
The previous image optimization step could fail with
write EPIPEerrors, causing the entire build to exit early. This PR ensures consistent and reproducible builds, especially on modern Node.js versions.How to test