feat: MaxConcurrentReconciles can be configured #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At $work we have several thousand namespaces in our production clusters, and in our development clusters >10k namespaces. Reconciliation can take >20 mins, because creation is not concurrent
There are two pieces of rate limiting in place (in istio-csr already)
reconciliation work
This change adjusts (2) so that we can increase the number of goroutines, so we can get configmaps created faster when a full reconciliation is occurring and a new namespace gets created (where the new namespace has to wait behind a full reconcile)
(There is also the option of improving the istio-csr use of priority queues, ie to prioritise creation, but I (or a colleague) will put that in another pull request)