Skip to content

Conversation

@tlwr
Copy link

@tlwr tlwr commented Jan 28, 2026

At $work we have several thousand namespaces in our production clusters, and in our development clusters >10k namespaces. Reconciliation can take >20 mins, because creation is not concurrent

There are two pieces of rate limiting in place (in istio-csr already)

  1. the kubernetes API client rate limiter
  2. the number of goroutines created by the controller runtime to do
    reconciliation work

This change adjusts (2) so that we can increase the number of goroutines, so we can get configmaps created faster when a full reconciliation is occurring and a new namespace gets created (where the new namespace has to wait behind a full reconcile)

(There is also the option of improving the istio-csr use of priority queues, ie to prioritise creation, but I (or a colleague) will put that in another pull request)

At $work we have several thousand namespaces in our production clusters,
and in our development clusters >10k namespaces.

Reconciliation can take >20 mins, because creation is not concurrent

There are two pieces of rate limiting in place

1) the kubernetes API client rate limiter
2) the number of goroutines created by the controller runtime to do
   reconciliation work

This change adjusts (2) so that we can increase the number of
goroutines, so we can get configmaps created faster when a
full reconciliation is occurring and a new namespace gets created
(where the new namespace has to wait behind a full reconcile)

(there is also the option of improving the istio-csr use of priority
queues, but I (or a colleague) will put that in another pull request)

Signed-off-by: toby lorne <toby@toby.codes>
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jan 28, 2026
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign erikgb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow
Copy link
Contributor

Hi @tlwr. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2026
@tlwr
Copy link
Author

tlwr commented Feb 5, 2026

/honk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant