feat(helm-chart): add ability to set pod level security context#558
feat(helm-chart): add ability to set pod level security context#558bryopsida wants to merge 1 commit intocert-manager:mainfrom
Conversation
Signed-off-by: bryopsida <8363252+bryopsida@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @bryopsida. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@bryopsida: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @hawksight I'll try this out given it is a helm chart improvement and report back. Within the next week or so. |
What
Adds a new helm value
app.podSecurityContextthat defaults to nil. When provided it acts as a pass through allowing users to adjust the pod level securityContext.Evidence
Template with defaults
Command used
helm template .Output
Template with podSecurityContext
Command used
helm template . --set app.podSecurityContext.seccompProfile.type=RuntimeDefaultOutput
Relates to: #147
Notes
I saw that the chart README.md is auto generated and the command to generate/update it looks to be
make generate-helm-docsbut this resulted in errors locally due to the detected version, is this something that needs to be updated in this PR and if so what's the best process to do so?