New Parser for JSON data

[kbrajneesh]

This parser can translate json key into harmonized key field and can create events from list of dict within key of JSON.

[ghost]

What if the data is in json["data.ipdata"]?

[kbrajneesh]

it will still work. if we have both json["data"]["ipdata"] and json["data.ipdata"], the one which is later defined, will override the other and its value will be assigned in key "data.ipdata" of flattened json.

[ghost]

If json_data_key can only be used in conjunction with json_data_format, why use two different parameters?

[ghost]

Thanks for the contribution! That's definitely a long-awaited parser :)

I only had a look at the added documentation so far.

[ghost]

Please expand the explanation, examples are also helpful.

[kbrajneesh]

json_data_format will be True if there is a single json and list of data is inside any of its child nodes. For below json, we find data inside key 'data'
{ "complete": false, "count": 9632240, "data": [ { "ip": "179.124.36.196", "classification": "malicious", "first_seen": "2020-01-13", "last_seen": "2020-12-14", "tags": [ "SSH Scanner", "SSH Worm" ], "cve": [] }, { "ip": "189.86.227.150", "classification": "malicious", "first_seen": "2019-01-17", "last_seen": "2020-12-14", "tags": [ "Eternalblue", "SMB Scanner" ], "cve": [ "CVE-2017-0144" ] } ], "message": "ok" }

[ghost]

Can you please add that example to the docs?

[ghost]

Please expand the explanation, examples are also helpful.

[kbrajneesh]

Again in above json, if we have config json_data_key: data and json_data_format : True, it will create two event with list of data present in json["data"] with proper harmonized field as per given in translate_field parameter.

[ghost]

Why are json_data_format and splitlines mutually exclusive?

Btw, I think there's no test that covers actual line splitting (the tests with splitlines=true only have one line)

[ghost]

Hi, thanks a lot for your contribution! That looks like a very useful parser. Could you make your commit messages a bit more verbose? It would be great if the information you added in the pull request would be part of the commit message, i.e.

Add a new JSONCustom parser Bot

JSON Custom Parser allows can translate json key into harmonized key field 
and can create events from list of dict within key of JSON

and for the documentation commit (if you want to keep that separate - you could also simply squash to one commit!)

DOC: add documentation for the JSON Custom Parser

The JSON Custom Parser converts from a custom JSON-String into an Event.
This adds an explanation and examples to the Bot documentation.

Also there are a lot of unnecessary changes in the bots.rst file, it seems your editor somehow tries to change spaces in the whole file? See 35ff026 - it would be great if that could be fixed.

[kbrajneesh]

Hi, all requested changes have been made in previous commit.

[ghost]

That bot is actually on the whishlist, so if you can contribute an entry to feeds.yaml that would be nice :)