Replace to isinstance#2637
Draft
Spiritedswordsman wants to merge 26 commits intocerttools:developfrom
Draft
Conversation
sebix
requested changes
Aug 14, 2025
Member
sebix
left a comment
sebix
left a comment
There was a problem hiding this comment.
Looked at a few files and found various sloppiness errors.
That also indicates that you didn't even try to run the tests.
Please review once again.
sebix
requested changes
Aug 15, 2025
Member
sebix
left a comment
sebix
left a comment
There was a problem hiding this comment.
Slightly better, but you still missed two in the list:
intelmq/lib/test.py: elif issubclass(type(msg), message.Message):intelmq/lib/message.py: if dict_eq and issubclass(type(other), Message):
Member
|
Have a look at the failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings updates to various files as mentioned in the issue #2636 where
type()is replaced byisinstance()Closes #2636