Drop privileges before creating temporary directory#2667
Merged
sebix merged 1 commit intocerttools:developfrom Nov 7, 2025
Merged
Drop privileges before creating temporary directory#2667sebix merged 1 commit intocerttools:developfrom
sebix merged 1 commit intocerttools:developfrom
Conversation
Otherwise, when the tests are run as root, the temporary directory gets created as root, but the cleanup code runs with dropped privileges, so it cannot remove it.
Contributor
Author
|
This makes no practical difference in GitHub CI, since its runners are regular users. However, we want to run tests in our internal CI as well, and there, the runners are root. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, when the tests are run as root, the temporary directory gets created as root, but the cleanup code runs with dropped privileges, so it cannot remove it.