This repository was archived by the owner on Jan 6, 2022. It is now read-only.
Conversation
Owner
|
I've started reviewing the changes so far and will get back to you when I have some feedback or other points! It's looking great so far, so I think it will be only minor points. Anyway, let me know when the click implementation is at a "ready-ish" stage and I will do some testing of functionality/usability compared to the previous implementation. Also, don't worry about merging this pull request with any newer changes on master. I will handle those at a later point. Again, thanks for your very large contribution! |
chadsr
force-pushed
the
master
branch
2 times, most recently
from
3eadfeb to
b9ef1c7
Compare
chadsr
force-pushed
the
master
branch
7 times, most recently
from
f8f765e to
7119810
Compare
chadsr
force-pushed
the
master
branch
2 times, most recently
from
15ae880 to
74714e1
Compare
Repository owner
deleted a comment from
sebspion
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli rework and some refactoring of components touching rework. WIP