Open
Conversation
atenjin
reviewed
Jan 1, 2024
| runner.sync_run(|mut config| { | ||
| let components = new_partial::< | ||
| chainx_runtime::RuntimeApi, | ||
| chainx_executor::ChainXExecutor, |
Contributor
There was a problem hiding this comment.
we have 3 type runtime, maybe re-use the macro construct_async_run
| let bytes = hex::decode(&self.bytes).expect("require hex string without 0x"); | ||
| let epoch: EpochChangesFor<chainx_runtime::Block, Epoch> = | ||
| Decode::decode(&mut &bytes[..]).expect("Decode must success"); | ||
| println!("epoch: {:?}", epoch); |
Contributor
There was a problem hiding this comment.
we can change the println! to log?
|
|
||
| client | ||
| .insert_aux(&[(BABE_EPOCH_CHANGES_KEY, &epoch.encode()[..])], &[]) | ||
| .expect("Insert to db must success"); |
Contributor
There was a problem hiding this comment.
those expect can change to Err and using ?
atenjin
reviewed
Jan 1, 2024
Contributor
There was a problem hiding this comment.
I advice not commit this file in git? I think provide this file in validator doc is more batter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.