Draft
Conversation
Collaborator
|
I'm confused by some of the test fails - does a clean PR fail at the moment (due to a system update?) or has this PR got some unintended side effect? |
Contributor
Member
Author
|
That seems to be the case, I haven't looked into why MacOS failed yet, and style failed because I touched PAL. |
Member
Author
|
With these changes (there are a couple of things needing better checks or further investigation) my build hits a wall with system libicu, which is a lot newer than Linux system version or the one we embed. |
Use 'gmake' instead of 'make' on FreeBSD, confirm it is available in CMake.
Allow enabling ccache from bare CMake build and make sure both ways do the same thing.
Reuse existing implementation, but change the include from sysctl.h to resource.h - that should still work on other POSIX platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.